[INFRA] Improve asf.yaml to reduce the notifications#25
Merged
jerryshao merged 1 commit intoapache:masterfrom Jul 5, 2022
Merged
[INFRA] Improve asf.yaml to reduce the notifications#25jerryshao merged 1 commit intoapache:masterfrom
jerryshao merged 1 commit intoapache:masterfrom
Conversation
jerryshao
changed the title
jerryshao
commented
Jul 5, 2022
| issues: dev@uniffle.apache.org | ||
| pullrequests: notifications@uniffle.apache.org | ||
| commits: commits@uniffle.apache.org | ||
| issues: dev@uniffle.apache.org |
Contributor
Author
There was a problem hiding this comment.
Issues will still go to dev@ to notify all the subscribers.
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=========================================
Coverage 56.29% 56.29%
Complexity 1168 1168
=========================================
Files 152 152
Lines 8401 8401
Branches 813 813
=========================================
Hits 4729 4729
Misses 3408 3408
Partials 264 264 Continue to review full report at Codecov.
|
roryqi
pushed a commit
that referenced
this pull request
Jul 5, 2022
### What changes were proposed in this pull request? Fix the issues introduced in #25 to correct the notifications. ### Why are the changes needed? Reduce the PR comment noise in dev@. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update the asf.yaml to reduce the PR notifications to dev@
Why are the changes needed?
Currently there're some many gitbox notifications to dev@, which is actually duplicated with GH notification itself, so trying to reduce this in dev@
Does this PR introduce any user-facing change?
No
How was this patch tested?
NA